-
Notifications
You must be signed in to change notification settings - Fork 19.9k
Fixes #3359 #3873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #3359 #3873
Conversation
siddhant2002
commented
Feb 11, 2023
- I have read CONTRIBUTING.md.
- This pull request is all my own work -- I have not plagiarized it.
- All filenames are in PascalCase.
- All functions and variable names follow Java naming conventions.
- All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which algorithm is that?
It displays all the paths from source to target |
@siriak please check the updated pr |
src/main/java/com/thealgorithms/backtracking/AllPathsFromSourceToTarget.java
Outdated
Show resolved
Hide resolved
src/main/java/com/thealgorithms/backtracking/AllPathsFromSourceToTarget.java
Outdated
Show resolved
Hide resolved
@siriak I've done the necessary changes. Please check the pr. The return type cannot be changed to int [ ][ ] as the junit are being used. |
src/main/java/com/thealgorithms/backtracking/AllPathsFromSourceToTarget.java
Outdated
Show resolved
Hide resolved
src/main/java/com/thealgorithms/backtracking/AllPathsFromSourceToTarget.java
Outdated
Show resolved
Hide resolved
src/main/java/com/thealgorithms/backtracking/AllPathsFromSourceToTarget.java
Outdated
Show resolved
Hide resolved
src/main/java/com/thealgorithms/backtracking/AllPathsFromSourceToTarget.java
Outdated
Show resolved
Hide resolved
src/main/java/com/thealgorithms/backtracking/AllPathsFromSourceToTarget.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, please fix failing tests
Error: AllPathsFromSourceToTargetTest.testForFirstCase:18 iterable contents differ at index [0][0], expected: <0> but was: <2>
Error: AllPathsFromSourceToTargetTest.testForFourthcase:51 iterable contents differ at index [0][2], expected: <3> but was: <2>
Error: AllPathsFromSourceToTargetTest.testForThirdCase:40 iterable contents differ at index [0][0], expected: <0> but was: <1>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!